Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix CI issues due to unintended fake tensor creation in torch.compile tests #3416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fix CI issues due to unintended fake tensor creation in torch.compile tests #3416

wants to merge 3 commits into from
+41 −34

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Feb 26, 2025

Description

FakeTensors are being created instead of torch.Tensors within a torch.compile session. Although TRT engine gets compiled successfully, torch dynamo reports some strange guard failures due to these unused FakeTensors within the session.

Fixes #3415
Fixes #3393

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044 peri044 requested a review from narendasan February 26, 2025 19:26
@github-actions github-actions bot added component: tests Issues re: Tests component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 26, 2025
@peri044 peri044 mentioned this pull request Feb 26, 2025
Closed
@github-actions github-actions bot removed the component: tests Issues re: Tests label Feb 26, 2025
narendasan
narendasan reviewed Feb 27, 2025
View reviewed changes
py/torch_tensorrt/dynamo/utils.py

return torchtrt_inputs_dict
elif isinstance(inputs, dict):
torchtrt_inputs_dict: Dict[Any, Any] = dict()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be str: Any?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. This was not changed but the linter just restructured it. I'll modify it

narendasan
narendasan approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, small details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
3 participants
@peri044 @narendasan @facebook-github-bot